Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gareth Bacon MP's page still says he's a London Assembly member #132

Open
abibroom opened this issue Sep 7, 2020 · 4 comments
Open

Gareth Bacon MP's page still says he's a London Assembly member #132

abibroom opened this issue Sep 7, 2020 · 4 comments

Comments

@abibroom
Copy link

abibroom commented Sep 7, 2020

https://www.theyworkforyou.com/mp/25750/gareth_bacon/orpington

@dracos
Copy link
Member

dracos commented Sep 8, 2020

He still is a LA member, according to https://www.london.gov.uk/people/assembly
The person page shows the most recent membership there, which if there are two things current will be one of them (I assume at random). I guess it really should show all current memberships there; it used to do this until mysociety/theyworkforyou@633d70e - @zarino any thoughts?

@zarino
Copy link
Member

zarino commented Sep 8, 2020

Yay, edge cases.

So back when we redesigned, the aim of this bit of the person header was to display the position(s) a person might be most well known for. ISTR we guessed that would probably be their most recent appointment.

There’s probably space in the header for us to include two positions, if they’re both current. But what we want to avoid is displaying a laundry list of committee appointments etc below people’s names.

@dracos
Copy link
Member

dracos commented Sep 8, 2020

It never included committees/office posts, this was only about actual "house" membership :)

It used to do concatenation-of-house-memberships (e.g. MP/Former MP, MLA/Former MLA, MSP/Former MSP) and that line would be overridden by one non-committee office (e.g. minister), so was only ever one line.
It now does one non-committee office (e.g. minister) if relevant, and one current house membership (see e.g. the PM: https://www.theyworkforyou.com/mp/10999/boris_johnson/uxbridge_and_south_ruislip ).

I doubt anyone has more than two current memberships, yeah, though theoretically possible, I guess.

@dracos
Copy link
Member

dracos commented Oct 19, 2021

This issue was fixed because he is no longer an Assembly Member. The only people with two now are https://www.theyworkforyou.com/mp/25531/douglas_ross/moray (also an MP), and https://www.theyworkforyou.com/peer/11963/baroness_clark_of_kilwinning (covered I guess because it says MSP but also Baroness).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants