From 88c70fe9bbb96c9c7885d9046c193293cc614fa4 Mon Sep 17 00:00:00 2001 From: Gareth Rees Date: Fri, 22 Nov 2024 12:33:59 +0000 Subject: [PATCH] Remove broken Google Chart Has been deprecated since 2012 and they've actually removed it over the last year. Would be nice to replace with something else, but for now this just removes the broken element. Fixes https://github.com/mysociety/alaveteli/issues/2366 --- app/views/request_game/play.html.erb | 15 ++++++--------- doc/CHANGES.md | 1 + 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/app/views/request_game/play.html.erb b/app/views/request_game/play.html.erb index e120b65481..98edff6d37 100644 --- a/app/views/request_game/play.html.erb +++ b/app/views/request_game/play.html.erb @@ -2,15 +2,12 @@

- <%= image_tag "https://chart.googleapis.com/chart?chs=250x125&cht=gom&chd=t:#{@percentage}", - :size => "250x125", - :alt => "A chart showing #{@percentage}% of requests have been categorised", - :title => "#{@percentage}% of requests have been categorised" %> -
<%= n_("{{number_of_requests}} request left to categorise / {{total_number_of_requests}} total", - "{{number_of_requests}} requests left to categorise / {{total_number_of_requests}} total", - @missing, - :number_of_requests => number_with_delimiter(@missing), - :total_number_of_requests => number_with_delimiter(@total)) %> +
+ <%= n_('{{number_of_requests}} request left to categorise / {{total_number_of_requests}} total', + '{{number_of_requests}} requests left to categorise / {{total_number_of_requests}} total', + @missing, + number_of_requests: number_with_delimiter(@missing), + total_number_of_requests: number_with_delimiter(@total)) %>

<%= _("Top recent players") %>

diff --git a/doc/CHANGES.md b/doc/CHANGES.md index fe71fd47ae..e15c8c18b0 100644 --- a/doc/CHANGES.md +++ b/doc/CHANGES.md @@ -2,6 +2,7 @@ ## Highlighted Features +* Remove deprecated Google Chart from request game (Gareth Rees) * Migrated from Stripe Plans to Stripe Prices (Graeme Porteous) * Change notes so that records tagged with `name:value` will be associated with notes tagged as `name` (Graeme Porteous)