Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOM crash while sending out a batch of requests #8184

Closed
laurentS opened this issue Mar 28, 2024 · 2 comments
Closed

OOM crash while sending out a batch of requests #8184

laurentS opened this issue Mar 28, 2024 · 2 comments
Labels
f:batch-creation improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:france

Comments

@laurentS
Copy link
Contributor

We had the OOM Killer show up today while a batch was being sent to ~1050 public bodies. Once I restarted nginx everything resumed without problems, but that memory issue should not have happened.

There was no particularly high traffic on the site when this happened. The ruby process was using over 2GB of RAM when it was killed, which looks like a memory leak to me (or at least a linearly growing memory footprint with the size of the batch, if it's not a "leak" 😉). This was with alaveteli 0.43.1.0.

I will investigate further and report back here (hopefully with a fix).

This is similar to #7829 which was merged in 0.44.0.0 but in a slightly different context (sending the batch, as opposed to expiring embargo).

@garethrees garethrees added f:batch-creation improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:france labels Apr 2, 2024
@garethrees
Copy link
Member

FWIW we set the maximum batch size at 500.

a linearly growing memory footprint with the size of the batch, if it's not a "leak"

Yeah this sounds quite plausible.

@garethrees
Copy link
Member

This is desirable, but unlikely to be worked on in the next 12 months so closing for now.

@garethrees garethrees closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:batch-creation improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:france
Projects
None yet
Development

No branches or pull requests

2 participants