-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add images to body notes #7160
Comments
Some comments summarised from #6586:
I've renamed this to be about images rather than logos, since the latter is covered in #6172 and I think has some slightly different concerns. |
Noting the moment of travel on #1155 - would ActiveStorage variants help us here? |
I didn't see a problem with them appearing on the request forms. It does trigger the display of the notes field when there are no text based notes though. Having the "About" title with text is not ideal. |
I thought as we already had tickets for general images and logos for body pages we could have a new one (this one) for a system for users, including public body users, to submit/suggest such images. That was my intention with this ticket. Such a ticket for submission of images could be started again given the direction this ticket has taken. |
Done: #7165 |
Yep, that's what we'd use.
Hmm, yeah, this isn't good. The pro interface is intentionally utilitarian, and this adds extra ornament that ought not to appear.
That's for WDTK, not Alaveteli.
That's an enhancement to this – we don't even have the basic functionality to properly attach images yet, which is a design problem in its own right. Once we've figured out what we want and where to put them, a suggestion workflow can be thought about. |
From @garethrees at #6586 (comment)
TheyWorkForYou has images behind text at eg. https://www.theyworkforyou.com/mp/10001/diane_abbott/hackney_north_and_stoke_newington/divisions?policy=1049 |
This issue has been automatically closed due to a lack of discussion or resolution for over 12 months. |
See example in the screenshot.
Related:
The text was updated successfully, but these errors were encountered: