Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images to body notes #7160

Closed
RichardTaylor opened this issue Jul 14, 2022 · 9 comments
Closed

Add images to body notes #7160

RichardTaylor opened this issue Jul 14, 2022 · 9 comments
Labels
enhancement Adds new functionality f:authorities stale Issues with no activity for 12 months user-experience x:uk

Comments

@garethrees garethrees changed the title System for allowing users, and public bodies, to suggest, and upload, images and logos for use on body pages Add images and logos to body pages Jul 14, 2022
@garethrees garethrees changed the title Add images and logos to body pages Add images to body pages Jul 14, 2022
@garethrees garethrees changed the title Add images to body pages Add images to body notes Jul 14, 2022
@garethrees
Copy link
Member

garethrees commented Jul 14, 2022

Some comments summarised from #6586:

  • Pages without the images look dull in comparison
  • Marginally more preference towards the banner style, but general approval of both
  • There could be performance implications (though this can be mitigated by resizing & compressing on upload)
  • Current positioning pushes make a request CTA and request archive further down the page. That's not to say this isn't worth doing, but it is a thing to consider.

I've renamed this to be about images rather than logos, since the latter is covered in #6172 and I think has some slightly different concerns.

@mdeuk
Copy link
Collaborator

mdeuk commented Jul 14, 2022

* There could be performance implications (though this can be mitigated by resizing & compressing on upload)

Noting the moment of travel on #1155 - would ActiveStorage variants help us here?

@FOIMonkey
Copy link
Collaborator

Sadly, they don't look great on the pro request form:
2022-07-15

@RichardTaylor
Copy link
Author

Sadly, they don't look great on the pro request form:

I didn't see a problem with them appearing on the request forms. It does trigger the display of the notes field when there are no text based notes though. Having the "About" title with text is not ideal.

@RichardTaylor
Copy link
Author

changed the title System for allowing users, and public bodies, to suggest, and upload, images and logos for use on body pages Add images and logos to body pages

I thought as we already had tickets for general images and logos for body pages we could have a new one (this one) for a system for users, including public body users, to submit/suggest such images. That was my intention with this ticket. Such a ticket for submission of images could be started again given the direction this ticket has taken.

@RichardTaylor
Copy link
Author

Such a ticket for submission of images could be started again given the direction this ticket has taken.

Done: #7165

@garethrees
Copy link
Member

Noting the moment of travel on #1155 (comment) would ActiveStorage variants help us here?

Yep, that's what we'd use.

Sadly, they don't look great on the pro request form:

I didn't see a problem with them appearing on the request forms.

Hmm, yeah, this isn't good. The pro interface is intentionally utilitarian, and this adds extra ornament that ought not to appear.

I thought as we already had tickets for general images

That's for WDTK, not Alaveteli.

for a system for users, including public body users, to submit/suggest such images

That's an enhancement to this – we don't even have the basic functionality to properly attach images yet, which is a design problem in its own right. Once we've figured out what we want and where to put them, a suggestion workflow can be thought about.

@RichardTaylor
Copy link
Author

From @garethrees at #6586 (comment)

Can do some pretty fancy CSS these days so might be able to make these more of a background banner.

TheyWorkForYou has images behind text at eg.

https://www.theyworkforyou.com/mp/10001/diane_abbott/hackney_north_and_stoke_newington/divisions?policy=1049
Screenshot 2022-07-19 at 19 06 43

@HelenWDTK HelenWDTK added the stale Issues with no activity for 12 months label Nov 19, 2024
@HelenWDTK
Copy link
Contributor

This issue has been automatically closed due to a lack of discussion or resolution for over 12 months.
Should we decide to revisit this issue in the future, it can be reopened.

@HelenWDTK HelenWDTK closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds new functionality f:authorities stale Issues with no activity for 12 months user-experience x:uk
Projects
None yet
Development

No branches or pull requests

5 participants