Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ssl connection with SNI #172

Closed
UnamedRus opened this issue Nov 16, 2020 · 1 comment
Closed

Add support for ssl connection with SNI #172

UnamedRus opened this issue Nov 16, 2020 · 1 comment

Comments

@UnamedRus
Copy link

Describe the bug
It looks like that driver doesn't support SNI, so it can't connect to clickhouse server behind proxy with SNI.

To Reproduce
https://docs.python.org/3/library/ssl.html

Since Python 3.2 and 2.7.9, it is recommended to use the SSLContext.wrap_socket() of an SSLContext instance to wrap sockets as SSLSocket objects. The helper functions create_default_context() returns a new context with secure default settings. The old ssl.wrap_socket() function is deprecated since it is both inefficient and has no support for server name indication (SNI) and hostname matching.

sock = ssl.wrap_socket(sock, **ssl_options)

@xzkostyan
Copy link
Member

Hi.

Fix was merged into master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants