feat(sync): remove sync.useCache #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fritzduchardt I want you to check this out in particular. Did I miss something? |
No, looks good. The directory arg on app.runVendirSync could also go for now. However, once we centralize the caching, I suggest we go back to caching by default, which means the cache flag would need to get reintroduced. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #151 +/- ##
==========================================
+ Coverage 54.98% 55.46% +0.48%
==========================================
Files 23 23
Lines 2328 2268 -60
==========================================
- Hits 1280 1258 -22
+ Misses 849 823 -26
+ Partials 199 187 -12 ☔ View full report in Codecov by Sentry. |
mykso-bot
added a commit
that referenced
this pull request
Dec 22, 2023
# [3.0.0](v2.2.0...v3.0.0) (2023-12-22) ### Bug Fixes * consistent error logging with stderr and offending cmd ([#143](#143)) ([d9ed5ad](d9ed5ad)) * **smart mode:** detect changes in untracked files ([#144](#144)) ([524a3c5](524a3c5)) ### Features * plugin implementation ([#148](#148)) ([f23a41b](f23a41b)) * **sync:** deprecate sync.useCache and flip its default value ([#150](#150)) ([dcce7fc](dcce7fc)) * **sync:** remove sync.useCache ([#151](#151)) ([3962b73](3962b73)) ### BREAKING CHANGES * **sync:** users have to remove the sync section from their configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: users have to remove the
syncsection from their configurations.