Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central Caching #134

Closed
fritzduchardt opened this issue Dec 7, 2023 · 3 comments · Fixed by #274
Closed

Central Caching #134

fritzduchardt opened this issue Dec 7, 2023 · 3 comments · Fixed by #274
Assignees
Labels
enhancement New feature or request

Comments

@fritzduchardt
Copy link
Collaborator

fritzduchardt commented Dec 7, 2023

We do cache workloads, but we fetch them once for each installation. This could be improved with a central cache to pull each workload only once for each workload.

This would also allow us to add application folders in the envs directory structure, only if they really need extra configuration.

@fritzduchardt fritzduchardt added the enhancement New feature or request label Dec 8, 2023
@fritzduchardt fritzduchardt self-assigned this Mar 17, 2024
@fritzduchardt
Copy link
Collaborator Author

fritzduchardt commented Mar 17, 2024

This is going to be a bigger rework, hence a proposal before starting to get my hands dirty:

Aims

  • If the same helm chart and config is used for several environments, we only pull it once.
  • We get rid of application-specific directories in the envs-dir structure, if there is no specific config overwrite

Implementation

  • We introduce a central vendir cache in the myks root with a flat hierarchy including a sub-dir for every vendir directory entry. The sub-dir has a readable name for usability plus a config digest for uniqueness:
.vendor
└── multus-cni-1.1.10-c5759806e4d5
  • We add the application-specific directories previously held in the envs-dir structure to the .myks -root directory, rebuilding the envs-dir structure, but hiding it from the user:
.myks
├── envs
│   └── my-cluster
│       └── multus-cni
│           ├── vendir.lock.yaml
│           └── vendir.yaml

@Zebradil
Copy link
Member

This sounds good and reasonable 👍

@kbudde kbudde linked a pull request Apr 14, 2024 that will close this issue
@Zebradil Zebradil self-assigned this May 10, 2024
@Zebradil Zebradil linked a pull request May 15, 2024 that will close this issue
4 tasks
@Zebradil
Copy link
Member

Implemented in #274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants