fix(render): fix panic if metadata.name is not set #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
side note: It should not happen, that a manifest has no name but I had a config issue and it happened. Myks just died with a panic. How to reproduce the error:
|
Zebradil
reviewed
Oct 30, 2023
Zebradil
approved these changes
Oct 30, 2023
|
Thanks for fixing this! Now I wonder if we should validate |
mykso-bot
added a commit
that referenced
this pull request
Oct 31, 2023
# [2.1.0](v2.0.4...v2.1.0) (2023-10-31) ### Bug Fixes * **init:** ignore top level .myks folder ([#116](#116)) ([b39eb8d](b39eb8d)) * **render:** fix panic if metadata.name is not set ([#123](#123)) ([cdf3266](cdf3266)) * **smart-mode:** correct detection of changes in "_env/argocd" ([#111](#111)) ([ec5dd1d](ec5dd1d)) * **smart-mode:** filter out deleted envs and apps ([93fa2e3](93fa2e3)), closes [#114](#114) ### Features * add metadata to ytt steps ([#119](#119)) ([6443a20](6443a20)) * **global-ytt:** log ytt output on error ([#120](#120)) ([a22f7aa](a22f7aa)) * **ui:** add smart-mode.only-print flag for debugging ([0a6349a](0a6349a))
Zebradil
pushed a commit
that referenced
this pull request
Nov 21, 2023
# [2.1.0](v2.0.4...v2.1.0) (2023-10-31) ### Bug Fixes * **init:** ignore top level .myks folder ([#116](#116)) ([b39eb8d](b39eb8d)) * **render:** fix panic if metadata.name is not set ([#123](#123)) ([cdf3266](cdf3266)) * **smart-mode:** correct detection of changes in "_env/argocd" ([#111](#111)) ([ec5dd1d](ec5dd1d)) * **smart-mode:** filter out deleted envs and apps ([93fa2e3](93fa2e3)), closes [#114](#114) ### Features * add metadata to ytt steps ([#119](#119)) ([6443a20](6443a20)) * **global-ytt:** log ytt output on error ([#120](#120)) ([a22f7aa](a22f7aa)) * **ui:** add smart-mode.only-print flag for debugging ([0a6349a](0a6349a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.