-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Set output file #107
Comments
@halohalospecial I also saw this in the source code, but for me linter-elm-make creates dist/elm.js Edit: Now I remember that I've change this locally. It would be nice if this option would be configurable |
I do not think it should be a feature. I think this should continue to simply be (more or less) a linter. The fact that we use elm-make behind the scenes is an implementation detail, to my mind, and should remain so. I don't think this package should be an interface to the full compiler. |
That's a pitty. Right now I've modfiied linter-elm-make so it outputs to dist/elm.js. I also have browsersync set and I'm compiling always Main. With that I don't have to set any watchers for '*.elm'. also I don't have to compile project twice. With simple save I can see linter output and also browser is refreshed with new changes. And elm-make isn't so fast so this feature would be desirable. |
Ideally linter should communicate with something like https://github.com/jonathandturner/rls |
@rofrol it sounds like you have a pretty neat setup going there! But even so I agree with @mybuddymichael. I think this package should stay a linter, and the fact that the compiler is what's used for linting should stay (as much as possible) and implementation detail. Just my 2 cents. |
@splodingsocks And the reality is you have to compile twice. In ideal world, linter would send compilation request to sth like rls. Since linter runs compiler directly, let people use the fruits of this labor. elm compiler is slow on big projects, we don't have incremental compilation, we don't have rls. That's what we have. Like I said I can modify linter locally, but that might not be ideal situation if we want to promote Elm as a nice platform for using. |
Relevant post by @rtfeldman:
https://groups.google.com/d/msg/elm-dev/aDWFBg72Wt4/5Lg_8p21BAAJ |
Of course, what Richard says makes sense, but we're a long way from getting there. I think adding an output file option would be a pragmatic solution for now -- Elm compile times are really not the best at the moment, and compiling twice just makes it so much worse. |
@mybuddymichael, @splodingsocks do you think a way to set
--output
should be a feature of this package? Right now, we have--output=/dev/null
. If I want to output to a .js file, I have to run elm-make in the command line with--output
set to the output file.Cc: @rofrol
The text was updated successfully, but these errors were encountered: