Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace synchronized method in MyBatisExceptionTranslator with ReentrantLock #1022

Closed
libedi opened this issue Oct 28, 2024 · 3 comments · Fixed by #1039
Closed

Replace synchronized method in MyBatisExceptionTranslator with ReentrantLock #1022

libedi opened this issue Oct 28, 2024 · 3 comments · Fixed by #1039

Comments

@libedi
Copy link

libedi commented Oct 28, 2024

No description provided.

@premiduseja
Copy link

Virtual threads are introduced in Java 21. Is your question around is mybatis-spring 3.x version making use for virtual threads?

@libedi
Copy link
Author

libedi commented Dec 9, 2024

Yes, that's right. To use virtual threads introduced in JDK21, it seems necessary to change the synchronized keyword in the MyBatisExceptionTranslator file to ReentrantLock.

@harawata harawata changed the title Does mybatis-spring 3.x version support virtual threads? Replace synchronized method in MyBatisExceptionTranslator with ReentrantLock Dec 9, 2024
@harawata harawata mentioned this issue Dec 9, 2024
Merged
@hazendaz
Copy link
Member

hazendaz commented Dec 9, 2024

@libedi Could you build from latest master and see if that solves the issue for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace synchronized method with Lock harawata/spring
3 participants
@hazendaz @libedi @premiduseja