-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc clarifications - PromiseKit with Obj/C / Getting Starting #456
Comments
PromiseKit 3.0 can be used for both Swift and Objective-C, it's just nicer when used with Swift. Legacy PromiseKit 1.x is pure Objective-C and is therefore nicer if you aren't using Swift. Apologies that the docs were not clear enough on this. Specifying a target in your Podfile is good practice but shouldn't be necessary (unless something was changed for Cocoapods 1.0). What issue did you run into? |
Thanks for the quick response. Yes, it sounds like they changed the API in Cocoapods 1.0 - I get When I did add a target, I got the following warning:
And then it didn't create a workspace project. As a sanity check, I tried with FYI, when I tried adding One caveat to all of this - I do have XCode 8.0 beta installed on my system. However I was opening and testing with XCode 7.3.1. Since AFNetworking was ok, this makes me think this is a non-issue. |
One other point of clarification, this project was created using one of the iOS application templates using Obj/C for a primary language. |
Ok! actually, turns out that I didn't think I was getting Obj/C headers as the example I was using in |
What confused you as to thinking PMK3 is just Swift? 2nd paragraph in README is:
So presumably some other part made you think this didn't apply to version 3? |
I think it was a combination of the install issue I was having, combined with the PromiseKit 3.0 paragraph only mentioning Swift. I am glad I was mistaken. Btw - Thanks for making such a great library! Time to unravel some existing code. ;)
|
So to close the loop I think there are two things to update.
|
Agreed. Docs really need to be gone through with a fine tooth comb at this point. Then again, a lot of things will probably be changing again with Swift 3.0 and PMK 4.0, so maybe it's not worth it just yet. I'll give myself a todo for these tasks though unless you'd like to submit a PR. |
@nathanhosselton - I was looking to see where the |
Website branch: https://github.com/mxcl/PromiseKit/tree/gh-pages |
I'm trying to get started with PromiseKit for an Obj/C project, and I ran into a few issues. Happy to make a PR to clarify.
target
:This seemed necessary regardless of the issue for #1.
Happy to make a PR for any changes, just curious what the right answer is.
The text was updated successfully, but these errors were encountered: