Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP-518/pyproject.toml support #828

Closed
birdcolour opened this issue Jul 26, 2021 · 1 comment · Fixed by #830
Closed

PEP-518/pyproject.toml support #828

birdcolour opened this issue Jul 26, 2021 · 1 comment · Fixed by #830
Milestone

Comments

@birdcolour
Copy link
Contributor

birdcolour commented Jul 26, 2021

Hi, absolutely love the tool! My team are absolutely hooked on Jupyter notebooks, and this is a really great way for me to start getting the review/refactoring process back under control 😄

Would you accept a PR that implements support for loading the configuration data from a project's pyproject.toml file, i.e. PEP-518 as an alternative to the jupytext.toml file? If so, I would be happy to try and contribute it!

(edit - wrong PEP)

@birdcolour birdcolour changed the title PEP-621/pyproject.toml support PEP-518/pyproject.toml support Jul 26, 2021
@mwouts
Copy link
Owner

mwouts commented Jul 27, 2021

Thank you @birdcolour , yes sure that would be awesome!

The functions that we use to find out and load the configuration files are in config.py, and some tests on these configuration files are in tests/test_config.py, tests/test_cm_config.py (for use within Jupyter) and in tests/test_cli_config.py (at the command line).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants