Use config in read and write functions #753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
config
argument to thejupytext.read(s)
andjupytext.write(s)
functions.This should help fixing #752
What remains to be done:
Thethat is not a good idea - the notebooks with no metadata don't store the format options, so for these notebook at least it makes sense to use the config also when reading them.config
is used only when saving (except for the rst2md conversion which has to be used when reading the file)default_metadata_filter
in favor ofmetadata_filter
, etc, and alsodefault_jupytext_formats
in favor offormats
(and provide backward compatibility) => The PR for that is at Normalize jupytext config options names #754