-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade library versions for compatibility with JupyterLab 2.0 #449
Conversation
Thanks, I've tried addressing these (and updating
I'm not sure what change on my end triggers this new error. |
2d5c7c8
to
4f9f94e
Compare
I think I found the two issues:
|
ed27c14
to
6c603bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
=======================================
Coverage 98.91% 98.91%
=======================================
Files 77 77
Lines 7573 7573
=======================================
Hits 7491 7491
Misses 82 82
Continue to review full report at Codecov.
|
Jean, I have documented the change in the CHANGELOG, and added a word about how to use the previous version of the extension with JupyterLab 1.x. in the README for the extension. Is that OK with you? Many thanks again for your contribution! |
d3d9029
to
b0d9327
Compare
Just fixed a typo in the PR reference but otherwise LGTM, thanks! Happy for this to be merged whenever. |
Excellent ! Thank you @jhelie ! |
I'm not sure this is the correct way of bumping jupytext but with these changes the extension works again with JupyterLab 2.0.