-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In JupyterLab 2.0: "The extension "jupyterlab-jupytext" is outdated." #448
Comments
Hi Marc, I've got a tentative PR at #449. Curious to know whether it was easy as that (I'm not a JS person). In any case I can confirm it worked on my machine following these changes. |
Hello Jean, thanks for contributing this! Yes indeed, my expectation is that we just need to bump the version of the libraries in the requirement, so I do think that you did it right. I have very minor comments on your PR, see #449 . But there is also a more important question... when should we ship this new version of the extension? I am afraid that it will be incompatible with JupyterLab 1.x... So, tell me what you think of the following proposal:
|
Hi Marc, thanks for the feedback. This makes a lot of sense to me. Is there an rc branch for |
Jean, I have updated your PR. If it's good for you we could release it in Jupytext 1.4.0 (I finally prefer to increase the minor version number, as we are going to break the compatibility with JupyterLab 1.0...) A few people are asking for this on twitter, until we do the release they can try the RC with:
|
While reading the latest plotly changelog, I see that they managed to make their JupyterLab extension work in both JupyterLab 1.x and 2.0. There extension only depends on
Cf. https://github.com/plotly/plotly.py/pull/2261/files We could give a try to that approach at some point later on... |
I realise that we probably cannot use the same trick as plotly, because there is no version 1.0 for |
The current version of the JupyterLab-jupytext extension is not compatible with JupyterLab 2.0.
A migration guide is available here.
The text was updated successfully, but these errors were encountered: