Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for C# and F# #429

Merged
merged 12 commits into from
Feb 16, 2020
Merged

Add support for C# and F# #429

merged 12 commits into from
Feb 16, 2020

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Feb 11, 2020

This provides support in Jupytext for C# and F# notebooks, cf. #427

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #429 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   98.94%   98.98%   +0.04%     
==========================================
  Files          75       77       +2     
  Lines        7645     7705      +60     
==========================================
+ Hits         7564     7627      +63     
+ Misses         81       78       -3
Impacted Files Coverage Δ
jupytext/metadata_filter.py 100% <ø> (ø) ⬆️
tests/test_read_dotnet_try_markdown.py 100% <100%> (ø)
tests/test_read_simple_csharp.py 100% <100%> (ø)
tests/test_active_cells.py 100% <100%> (ø) ⬆️
jupytext/version.py 100% <100%> (ø) ⬆️
jupytext/cell_metadata.py 98.29% <100%> (+1.61%) ⬆️
jupytext/magics.py 100% <100%> (ø) ⬆️
jupytext/jupytext.py 98.59% <100%> (-0.01%) ⬇️
jupytext/languages.py 100% <100%> (ø) ⬆️
jupytext/formats.py 98.35% <100%> (-0.32%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dec43d...575dd87. Read the comment docs.

'.robot': {'language': 'robotframework', 'comment': '#'}}
'.robot': {'language': 'robotframework', 'comment': '#'},
'.cs': {'language': 'csharp', 'comment': '//'},
'.fs': {'language': 'fsharp', 'comment': '//'}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two other file extensions for F#:

  • .fsx - F# scripting file, can be loaded directly into the F# Interactive process
  • .fsi - F# interface file (similar to OCAML interface files), used mostly in very large codebases to encapsulate code constructs

.fsi is probably not relevant to this project, but .fsx might be.

@mwouts
Copy link
Owner Author

mwouts commented Feb 13, 2020

I see that C# uses specific magic commands. See e.g. this notebook, which uses for instance:

#!html

<b>Hello!</b>

@mwouts mwouts merged commit 0fee67f into master Feb 16, 2020
@mwouts mwouts deleted the csharp_and_fsharp branch March 9, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants