Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to follow the listed for "Add support for another language". I do have some questions about the last point though.
Evcxr has special commands, which are not valid Rust in any way. In contrast to Python magic cells they start with
:
instead of%
, so they are not covered by the current logic for line magic.From the code it looked like changing the variables
_MAGIC_RE
/_MAGIC_FORCE_ESC_RE
might be the way to go here, but since I do not see any special casing there yet, I first wanted to know if that would be correct.Here is a list of the supported magics in Evcxr.
Rust identifiers can also contain
:
at the start, for example::std::mem::drop
.The difference is that Evcxr commands have exactly one and in identifiers it is always as
::
.The sample notebook stems from the Evcxr project, which provides a Rust kernel.
https://github.com/google/evcxr/blob/942e166965e47073a592864440acd59cb8f4dfe1/evcxr_jupyter/samples/evcxr_jupyter_tour.ipynb