Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .r extension for R files #122

Closed
wants to merge 2 commits into from
Closed

Conversation

kiendang
Copy link
Contributor

Allow .r which is a valid extension for R files.

@codecov
Copy link

codecov bot commented Nov 11, 2018

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          52       52           
  Lines        3737     3737           
=======================================
  Hits         3631     3631           
  Misses        106      106
Impacted Files Coverage Δ
jupytext/formats.py 96.89% <ø> (ø) ⬆️
jupytext/languages.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eccfba...f5ac885. Read the comment docs.

@mwouts
Copy link
Owner

mwouts commented Nov 11, 2018

Thanks @kiendang for the contribution - I agree that Jupytext should allow '.r' extension as well. I am a bit surprised that the change can be so small! Does it work well with only this change?

A possible list of tests would be

  • open .r file as notebooks in Jupyter
  • export to .r files using "jupytext": {"formats": "ipynb,r"}
  • convert .ipynb files from and to .r files using command line jupytext.

@kiendang
Copy link
Contributor Author

Yea sorry I only tested the first point. I have added a new commit that takes care of point 2 and 3.

@mwouts
Copy link
Owner

mwouts commented Nov 11, 2018

Great! I will have a look at this soon. Thanks Dang.

@mwouts mwouts mentioned this pull request Nov 12, 2018
@mwouts
Copy link
Owner

mwouts commented Nov 12, 2018

Integrated in version 0.8.5. Thanks @kiendang !

@mwouts mwouts closed this Nov 12, 2018
@kiendang kiendang deleted the r-extension branch November 13, 2018 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants