Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the codecov comments on the PRs #1171

Closed
mwouts opened this issue Nov 24, 2023 · 2 comments · Fixed by #1173
Closed

Restore the codecov comments on the PRs #1171

mwouts opened this issue Nov 24, 2023 · 2 comments · Fixed by #1173
Milestone
1.16.0

Comments

@mwouts
Copy link
Owner

mwouts commented Nov 24, 2023

I don't see anymore the codecov comments on the PR - not sure the codecov.yml file is effective anymore? cc @LecrisUT
@mwouts mwouts added this to the 1.16.0 milestone Nov 24, 2023
@LecrisUT
Copy link
Contributor

The number of tests you have in the codecov.yml (after_n_builds) is too many (experimental tests do not upload to codecov). I think you can even put after_n_builds directly to individual flags. Or you can try wait_for_ci

@mwouts mwouts mentioned this issue Nov 24, 2023
Merged
@mwouts
Copy link
Owner Author

mwouts commented Nov 25, 2023

Yes - apparently it's the conda builds that fail to upload the coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.16.0
Development

Successfully merging a pull request may close this issue.

Restore the codecov comments on PRs mwouts/jupytext
2 participants
@LecrisUT @mwouts