Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlparse1 maintenance #3

Open
4 tasks
mwhooker opened this issue Aug 29, 2014 · 2 comments
Open
4 tasks

urlparse1 maintenance #3

mwhooker opened this issue Aug 29, 2014 · 2 comments

Comments

@mwhooker
Copy link
Owner

We include the source from cpython's urlparse module in order to avoid hacking up sys.modules as documented in 4f77827

I'd like to

  • document why we did this
  • write a test to prove this works well with urlparse (assuming that's why we did this)
  • update urlparse1.py with latest version
  • possibly roll this back if at all possible. I want to roll back b/c of code rot

cc @brainsik @glyphobet

@glyphobet
Copy link
Collaborator

I have no idea why this was done; best guess was that we were trying not to have urlparse in sys.modules when someone imports urlparse2, but I don't see why that would be a problem.

@brainsik
Copy link
Collaborator

brainsik commented Sep 2, 2014

So long ago. I don't remember either. Well perhaps you'll run into whatever problem it was we were working around. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants