Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New distribution plot legends are not finalized #2113

Open
mwaskom opened this issue Jun 1, 2020 · 1 comment
Open

New distribution plot legends are not finalized #2113

mwaskom opened this issue Jun 1, 2020 · 1 comment

Comments

@mwaskom
Copy link
Owner

mwaskom commented Jun 1, 2020

I did not want this to hold up #2104, because legends need serious rethinking at the core level. But I will note that the implementation of legends in the new kdeplot and rugplot are limited:

  • legend only accepts True/False, not brief/full
  • The legend uses proxy artists that do not get added to the plot. This may be superior, but it means that re-calling legend (including from a subsequent seaborn function) will erase the original legend, rathe than expand it.
  • The representation of filled kernel densities is not ideal; see notes in the code.
  • It would be ideal to have the bivariate legend represent contour intensity information too, and then we could remove colorbar support (which shows ticks in terms of density values, not iso-proportions) (although we could also re-label the ticks with the levels, maybe).
  • The rugplot legend should actually look like the rug, rather than using a generic line.
@mwaskom
Copy link
Owner Author

mwaskom commented Aug 28, 2020

Deferring until some of the challenges in #2231 are sorted out

@mwaskom mwaskom modified the milestones: v0.11.0, v0.12.0 Aug 28, 2020
@mwaskom mwaskom modified the milestones: v0.12.0, v0.13.0 Jul 30, 2022
@mwaskom mwaskom modified the milestones: v0.13.0, v0.14.0 Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant