Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorView not working on 2.1.5 version #171

Open
avdhootu27 opened this issue May 2, 2024 · 7 comments
Open

ErrorView not working on 2.1.5 version #171

avdhootu27 opened this issue May 2, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@avdhootu27
Copy link

I have an error view in my vaadin app which is supposed to be shown when user tries to open a view which doesn't exist.
When I was on vaadin 23 and karibu-testing-v10-spring 1.3.24, I had a test running successfully in which I was navigating to a view which doesn't exist, and I was testing if it returns my ErrorView.
Now I am on vaadin 24.3.10 and karibu-testing-v10-spring 2.1.5, the test is failing, it is returning the home (default) view.
Why this test is failing on vaadin 24 karibu 2.1.5? The expected behaviour is it returns ErrorView.

@mvysny
Copy link
Owner

mvysny commented May 2, 2024

Can you please provide a simple code which reproduces the issue?

@mvysny mvysny self-assigned this May 2, 2024
@mvysny mvysny added bug Something isn't working question Further information is requested labels May 2, 2024
@avdhootu27
Copy link
Author

@mvysny
Here are 2 projects which has ErrorView functional (in both), one with vaadin 23, karibu 1.3.24 and another with vaadin 24 and karibu 2.1.5.

In vaadin 23 and karibu 1.3.24, the test is passing
In vaadin 24 and karibu 2.1.5, the test is not passing (ErrorView is not getting rendered in test)

Functionality wise both are working as expected.
flow-spring-examples-v24.zip
flow-spring-examples-v23.zip

@mvysny mvysny removed the question Further information is requested label May 8, 2024
@avdhootu27
Copy link
Author

@mvysny will it be fixed in upcoming releases?

@avdhootu27
Copy link
Author

@mvysny any update?

@mvysny
Copy link
Owner

mvysny commented Jul 5, 2024

Could be related to #161

@mvysny
Copy link
Owner

mvysny commented Aug 1, 2024

Could be that you're using access checker and thus you're being hit by #161. #161 is fixed, closing this one as fixed as well. Please test with Karibu-Testing 2.1.7 and let me know whether it works.

@mvysny mvysny closed this as completed Aug 1, 2024
@avdhootu27
Copy link
Author

Tried 2.1.7 and 2.1.8, it doesn't work

@mvysny mvysny reopened this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants