Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isLessOrEquals function #74

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

JonathanXDR
Copy link
Contributor

@JonathanXDR JonathanXDR commented Oct 5, 2024

Fixes #72

Add isLessOrEquals function to the viewport manager.

  • src/runtime/manager.ts

    • Add isLessOrEquals function to check if the current breakpoint is less than or equal to the specified breakpoint.
    • Export the new isLessOrEquals function.
  • playground/pages/index.vue

    • Add example usage of viewport.isLessOrEquals function.
  • README.md

    • Add documentation for the new viewport.isLessOrEquals function.

For more details, open the Copilot Workspace session.

README.md Outdated Show resolved Hide resolved
@mvrlin
Copy link
Owner

mvrlin commented Oct 6, 2024

Hi, thank you for your PR!
Please fix icons in the README

@JonathanXDR JonathanXDR requested a review from mvrlin October 6, 2024 09:11
@mvrlin
Copy link
Owner

mvrlin commented Oct 6, 2024

@JonathanXDR Looking good, can you squash commits into a single one?

feat: add `isLessOrEquals` function

Fixes #72

Add `isLessOrEquals` function to the viewport manager.

* **src/runtime/manager.ts**
  - Add `isLessOrEquals` function to check if the current breakpoint is less than or equal to the specified breakpoint.
  - Export the new `isLessOrEquals` function.

* **playground/pages/index.vue**
  - Add example usage of `viewport.isLessOrEquals` function.

* **README.md**
  - Add documentation for the new `viewport.isLessOrEquals` function.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/mvrlin/nuxt-viewport/issues/72?shareId=XXXX-XXXX-XXXX-XXXX).
@JonathanXDR JonathanXDR force-pushed the add-isLessOrEquals-1 branch from 67f703b to f515237 Compare October 6, 2024 09:33
@mvrlin mvrlin changed the title Add isLessOrEquals function feat: add isLessOrEquals function Oct 6, 2024
@mvrlin mvrlin merged commit a521a3a into mvrlin:main Oct 6, 2024
@JonathanXDR JonathanXDR deleted the add-isLessOrEquals-1 branch October 6, 2024 09:36
@mvrlin
Copy link
Owner

mvrlin commented Oct 6, 2024

@JonathanXDR Thanks you, for your contribution! 💛

@JonathanXDR
Copy link
Contributor Author

No problem, thanks for the opportunity! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add isLessOrEquals Function
2 participants