Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up composition #108

Open
mvcisback opened this issue Mar 29, 2019 · 0 comments
Open

Speed up composition #108

mvcisback opened this issue Mar 29, 2019 · 0 comments

Comments

@mvcisback
Copy link
Owner

Currently, composition seems to scale super linearly in the size of the circuit. The appears to also hold true for all functions that rely on modify_leafs

https://github.com/mvcisback/py-aiger/blob/master/aiger/aig.py#L246

This function performs a recursive traversal of the DAG and modifies the leafs. However, currently this results in the entire DAG being rebuilt with each call of modify_leafs.

The proposal is to use a persistent datastructure that allows for targeted changes to the DAG.

Pyrsistent seems promising. Changing the NamedTuples with PRecords may do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant