Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This doesn't work with gatsby? #42

Open
mhedengren opened this issue Sep 5, 2020 · 4 comments
Open

This doesn't work with gatsby? #42

mhedengren opened this issue Sep 5, 2020 · 4 comments

Comments

@mhedengren
Copy link

mhedengren commented Sep 5, 2020

Somehow I cannot get this to work with gatsby, the safari toolbar in iOS is still covering the div. I'm using the FullHeightComponent on my index page within the Layout compontent.

repo: https://github.com/mhedengren/just-a-test

netlify for checkout on phone https://objective-kowalevski-bd15a4.netlify.app/

Am I doing something wrong?

@mvasin
Copy link
Owner

mvasin commented Sep 6, 2020

Hi Melker,

thanks for reporting and for the nice reproduction. Will look into it tomorrow.

@mvasin
Copy link
Owner

mvasin commented Sep 7, 2020

I spotted a problem with SSR and tried to so solve it - my attempt is already on master and published as [email protected]. It seems to work in iOS Chrome, but seems not to work in iOS Safari (I'm on iOS version 13.6.1).

The idea came from https://joshwcomeau.com/react/the-perils-of-rehydration/, but I suspect that some non-gatsby but SSRed apps may re-render unpredictable amount of times before getting flushing SSRed HTML to the client, so the proposed solution to render in two passes may not suit all.

@mhedengren I'm still exploring this issue and will keep you updated.

@mhedengren
Copy link
Author

I spotted a problem with SSR and tried to so solve it - my attempt is already on master and published as [email protected]. It seems to work in iOS Chrome, but seems not to work in iOS Safari (I'm on iOS version 13.6.1).

The idea came from https://joshwcomeau.com/react/the-perils-of-rehydration/, but I suspect that some non-gatsby but SSRed apps may re-render unpredictable amount of times before getting flushing SSRed HTML to the client, so the proposed solution to render in two passes may not suit all.

@mhedengren I'm still exploring this issue and will keep you updated.

Ok I see! Sounds great :) Many thanks for taking your time do to this.

@mvasin
Copy link
Owner

mvasin commented Nov 7, 2021

Hi @mhedengren! If you're still using the component, can you try out [email protected]? The API might have changed, please consult the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants