Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't work with laravel/framework v6.9.0 #3

Closed
4n70w4 opened this issue Dec 24, 2019 · 5 comments
Closed

Don't work with laravel/framework v6.9.0 #3

4n70w4 opened this issue Dec 24, 2019 · 5 comments

Comments

@4n70w4
Copy link

4n70w4 commented Dec 24, 2019 •
edited
Loading

afterCommitCreated don't fired via observer.
But work with 6.6.1
@mvanduijker
Copy link
Owner

Thanks for your report. It seems to stop working from 6.9 (6.8 still seemed to work) I got the tests to fail on master. Will take a look in the coming days. If you have time, feel free to make a PR.

@mvanduijker
Copy link
Owner

Did a bit more investigation, laravel/framework#30883 is the PR that broke it.

@mvanduijker
Copy link
Owner

I created an issue laravel/framework#30948. Let's see what happens. If it's gonna stick, I have to release a new version for Laravel 6.9+

@4n70w4
Copy link
Author

4n70w4 commented Dec 26, 2019

Maybe should make temporarily constraint the laravel version in dependencies of composer.

@mvanduijker
Copy link
Owner

The change in Laravel has been reverted and has been released (6.10.0). I released version 2.1.0 with a constraint not supporting Laravel 6.9.0.

Thanks for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvanduijker @4n70w4