Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for player-only <source> tag #284

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

luwes
Copy link
Collaborator

@luwes luwes commented Aug 2, 2024

fix #262

note that the support for this is purely player only for now.

the upload workflow still works but you might have to refresh the browser manually when the upload completes and pick the correct props from the imported asset to set in the source tag.

@luwes luwes self-assigned this Aug 2, 2024
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-video-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 4:27pm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (d7f4e39) to head (d328ab0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files          30       30           
  Lines        2423     2423           
  Branches      347      347           
=======================================
  Hits         2197     2197           
  Misses        226      226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luwes luwes merged commit e1ed50f into muxinc:main Aug 2, 2024
8 checks passed
@luwes luwes deleted the source-tag branch August 2, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't play videos that don't have an extension on iOS
3 participants