From d96f3054367ddacfbc5bace8eba550515c350307 Mon Sep 17 00:00:00 2001
From: Wesley Luyten <me@wesleyluyten.com>
Date: Tue, 10 Sep 2024 13:38:36 -0500
Subject: [PATCH 1/2] fix: position menu absolute in control bar to prevent
 taking space

---
 examples/vanilla/control-elements/media-captions-menu.html | 2 +-
 src/js/media-control-bar.ts                                | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/examples/vanilla/control-elements/media-captions-menu.html b/examples/vanilla/control-elements/media-captions-menu.html
index 9b0fc252f..adbffe2c6 100644
--- a/examples/vanilla/control-elements/media-captions-menu.html
+++ b/examples/vanilla/control-elements/media-captions-menu.html
@@ -46,7 +46,6 @@ <h1>Captions Menu</h1>
           <track label="Subs Russian" kind="subtitles" srclang="ru" src="../vtt/elephantsdream/captions.ru.vtt"></track>
           <track label="Subs Arabic" kind="subtitles" srclang="ar" src="../vtt/elephantsdream/captions.ar.vtt"></track>
         </video>
-        <media-captions-menu anchor="auto" hidden></media-captions-menu>
         <media-control-bar>
           <media-play-button></media-play-button>
           <media-seek-backward-button seekoffset="15"></media-seek-backward-button>
@@ -55,6 +54,7 @@ <h1>Captions Menu</h1>
           <media-time-range></media-time-range>
           <media-time-display showduration remaining></media-time-display>
           <media-captions-button></media-captions-button>
+          <media-captions-menu anchor="auto" hidden></media-captions-menu>
           <media-captions-menu-button></media-captions-menu-button>
           <media-fullscreen-button></media-fullscreen-button>
         </media-control-bar>
diff --git a/src/js/media-control-bar.ts b/src/js/media-control-bar.ts
index 92eec8df8..b8ec5064e 100644
--- a/src/js/media-control-bar.ts
+++ b/src/js/media-control-bar.ts
@@ -28,6 +28,10 @@ template.innerHTML = /*html*/ `
     ::slotted(media-clip-selector) {
       flex-grow: 1;
     }
+
+    ::slotted([role="menu"]) {
+      position: absolute;
+    }
   </style>
 
   <slot></slot>

From 0d137b3f9f989c30c718e6d8373f4de0dfb59615 Mon Sep 17 00:00:00 2001
From: Wesley Luyten <me@wesleyluyten.com>
Date: Tue, 10 Sep 2024 13:39:06 -0500
Subject: [PATCH 2/2] fix: remove unused props

---
 src/js/menu/media-chrome-menu.ts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/js/menu/media-chrome-menu.ts b/src/js/menu/media-chrome-menu.ts
index b8ae2baee..223b6c21c 100644
--- a/src/js/menu/media-chrome-menu.ts
+++ b/src/js/menu/media-chrome-menu.ts
@@ -307,8 +307,6 @@ class MediaChromeMenu extends globalThis.HTMLElement {
   #mediaController: MediaController | null = null;
   #previouslyFocused: HTMLElement | null = null;
   #invokerElement: HTMLElement | null = null;
-  #keysSoFar = '';
-  #clearKeysTimeout: number | null = null;
   #previousItems = new Set<MediaChromeMenuItem>();
   #mutationObserver: MutationObserver;
   #isPopover = false;