fix: position menu absolute in control bar #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent taking space
|
@luwes is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cjpillsbury
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
pre-approving/deferring to you on pref, but we should probably update docs for this. Mind either adding a followup issue or updating:
- Add a section to control bar docs a la https://www.media-chrome.org/docs/en/components/media-control-bar#use-with-media-time-range
- Update docs for each menu component, either linking to control bar section ☝️, updating examples to be more like https://www.media-chrome.org/docs/en/components/media-time-range, or something similar
|
We should also update our migration guide to explain how to go from old select menu architecture to your new menu architecture (not sure if an issue was ever created). |
|
@AdamJaggard updated the migration guide here #965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to prevent taking space