You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is based on my understanding. I believe the purpose of this method is to merge the two dictionaries representing the same entity.
Potential Issues:
While iterating over the primaryKeyPaths
id dictionaryValue = [dictionary valueForKeyPath:keyPath];
id protoRecordValue = [dictionary valueForKeyPath:keyPath]; //probably meant protoRecord.dictionary.
The check for dictionariesContainIdenticalPrimaryKeys is probably unnecessary as the caller is expected to call this only in that case.
Enhancement Suggestion:
I would suggest truly merging the two dictionaries (copy from dictionary to protoRecord.dictionary). Though I would generally expect this to have been the default behavior, since it should rarely be needed and you documented it very well, this could suggestion can be ignored.
The text was updated successfully, but these errors were encountered:
Good catch. I think you're right. There may be a bug there.
Currently there are no ongoing plans to ship a 1.4.2 milestone for MMRecord, but I am adding the issue to that module in any case just so we can have a clearer picture to the state of the framework.
This is based on my understanding. I believe the purpose of this method is to merge the two dictionaries representing the same entity.
Potential Issues:
While iterating over the primaryKeyPaths
id dictionaryValue = [dictionary valueForKeyPath:keyPath];
id protoRecordValue = [dictionary valueForKeyPath:keyPath]; //probably meant protoRecord.dictionary.
The check for dictionariesContainIdenticalPrimaryKeys is probably unnecessary as the caller is expected to call this only in that case.
Enhancement Suggestion:
The text was updated successfully, but these errors were encountered: