Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obj\[Configuration]\NuGet\[Guid] folder included in output #55

Open
svenkle opened this issue Apr 8, 2021 · 5 comments
Open

obj\[Configuration]\NuGet\[Guid] folder included in output #55

svenkle opened this issue Apr 8, 2021 · 5 comments

Comments

@svenkle
Copy link

svenkle commented Apr 8, 2021

Posting this for review/discussion or to help others.

There is a little/strange issue when GlassMapper and Helix Publish Profile are used in conjunction. Each project that references GlassMapper has a obj folder with the .cs and .config files from GlassMapper in a format similar to obj\[Configuration]\Nuget\[Guid]. Unfortunately this folder is copied to the publish target by HPP and it really shouldn't be there. To work around this I've updated my NuGet references as shown below:

<PackageReference Update="Glass.Mapper.Sc.100" Version="5.8.173">
    <IncludeAssets>compile</IncludeAssets>
</PackageReference>

Reference for NuGet: https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files

@muso31
Copy link
Owner

muso31 commented Apr 8, 2021

Hi @svenkle - this is logged in glass.... mikeedwards83/Glass.Mapper#432

Hopefully we'll get it fixed soon

@muso31 muso31 closed this as completed Apr 8, 2021
@svenkle
Copy link
Author

svenkle commented Apr 8, 2021

@muso31 sure it's a GlassMapper issue, but given the fact this repository depends on both GlassMapper and HPP wouldn't it be better to apply a fix until a time that it is resolved? There are many open issues and several PRs in that repository so it seems unlikely to be fixed any time soon.

@muso31
Copy link
Owner

muso31 commented Apr 8, 2021

@svenkle I have access to Glass as I'm helping maintain the solution, there's already a branch with a fix in place. We'll look into getting it tested and released asap - https://github.com/mikeedwards83/Glass.Mapper/tree/feature/loadingchanges

@muso31
Copy link
Owner

muso31 commented Apr 8, 2021

..Will also look into applying your fix in the meatime

@muso31 muso31 reopened this Apr 8, 2021
@svenkle
Copy link
Author

svenkle commented Apr 8, 2021

@svenkle I have access to Glass as I'm helping maintain the solution, there's already a branch with a fix in place. We'll look into getting it tested and released asap - https://github.com/mikeedwards83/Glass.Mapper/tree/feature/loadingchanges

Great! Can you also approve my PR in that repo 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants