You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, let me say well done for putting the client in its own package, makes things more flexible! (I was installing everything just to use the client)
Now for the server, having strict dependencies is not much of a problem cause it typically runs in its own container. But the client should be usable from any python program that wishes to talk to the server, so the requirements should be as relaxed as possible.
A specific problem: I want to use the client from AppDaemon, which I think is a very reasonable use-case for HA users. However, the latest AppDaemon requires aiohttp 3.8.X, which is a bit old but not that crazy (3.9 came out just last year!). So it cannot coexist with music-assistant-client which requires aiohttp>=3.9.
Is there a real reason for requiring aiohttp>=3.9? My guess would be no, cause music-assistant==2.3.2 required aiohttp without a version, and I was using the client from within AppDaemon without a problem. Upgrading to 2.3.3 caused the dependency regression.
If there is no real reason I would suggest changing it to at least aiohttp>=3.8, an in general try to make the client dependencies as relaxed as possible.
The text was updated successfully, but these errors were encountered:
First, let me say well done for putting the client in its own package, makes things more flexible! (I was installing everything just to use the client)
Now for the server, having strict dependencies is not much of a problem cause it typically runs in its own container. But the client should be usable from any python program that wishes to talk to the server, so the requirements should be as relaxed as possible.
A specific problem: I want to use the client from AppDaemon, which I think is a very reasonable use-case for HA users. However, the latest AppDaemon requires aiohttp 3.8.X, which is a bit old but not that crazy (3.9 came out just last year!). So it cannot coexist with music-assistant-client which requires aiohttp>=3.9.
Is there a real reason for requiring aiohttp>=3.9? My guess would be no, cause music-assistant==2.3.2 required aiohttp without a version, and I was using the client from within AppDaemon without a problem. Upgrading to 2.3.3 caused the dependency regression.
If there is no real reason I would suggest changing it to at least aiohttp>=3.8, an in general try to make the client dependencies as relaxed as possible.
The text was updated successfully, but these errors were encountered: