Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/complete grains at shape edge #335

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

JLeliaert
Copy link
Contributor

Adds a variable to ext_make3dgrains to complete all voronoi grains whose centre lies within the shape. This also cuts away parts of the shape whose closest voronoi centre lies outside the shape.

This allows e.g. to make polycrystalline geometries consisting of clustered individual grains.

clusterparticle

@JLeliaert
Copy link
Contributor Author

One of the functions (shufflecells) in make3dgrains used rand.perm to shuffle the cells around before assigning them a region number. This function used the global random generator, which as of go 1.20 is seeded automatically and therefore gives a different output for every run. I've replaced this with the seeded generator of the tessellation to have a deterministic output. I've adapted the test problem to reflect the newly obtained values (the previous test values were obtained with a go version <1.20 which was still deterministic)

@JonathanMaes JonathanMaes merged commit 5e89278 into 3.11 Oct 4, 2024
@JonathanMaes JonathanMaes deleted the feature/CompleteGrainsAtShapeEdge branch October 4, 2024 08:34
MathieuMoalic added a commit to MathieuMoalic/amumax that referenced this pull request Oct 4, 2024
@JonathanMaes JonathanMaes mentioned this pull request Oct 14, 2024
2 tasks
MathieuMoalic added a commit to MathieuMoalic/amumax that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants