Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to combine arrows with scalar colormaps #152

Merged
merged 2 commits into from
Jan 25, 2018
Merged

allow to combine arrows with scalar colormaps #152

merged 2 commits into from
Jan 25, 2018

Conversation

godsic
Copy link
Contributor

@godsic godsic commented Jan 25, 2018

Before this change mumax3-convert would normally output either:

m_xrange192-320_yrange192-320_012500

or

m_xrange192-320_yrange192-320_012500

After this change one can do something like this:
m_xrange192-320_yrange192-320_012500

@godsic godsic requested a review from a team January 25, 2018 16:08
@godsic
Copy link
Contributor Author

godsic commented Jan 25, 2018

@barnex not sure it is done in idiomatic way, but seems like this is the most compact version.

barnex
barnex approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@barnex barnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@barnex barnex merged commit e2c09f4 into master Jan 25, 2018
@barnex
Copy link
Member

barnex commented Jan 25, 2018

Thanks.

@JonathanMaes JonathanMaes deleted the mumax3-convert/arrows-vs-scalar-color branch October 7, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnex barnex barnex approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godsic @barnex