farm supply for week fix #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from 6cd702c to f5d2593
|
sasurobert
reviewed
Aug 1, 2024
| let boosted_rewards = self.claim_only_boosted_payment(user); | ||
| let boosted_rewards_payment = | ||
| EsdtTokenPayment::new(self.reward_token_id().get(), 0, boosted_rewards); | ||
|
|
||
| self.set_farm_supply_for_current_week(&storage_cache.farm_token_supply); |
There was a problem hiding this comment.
do we have to do this every single time ?
There was a problem hiding this comment.
We could also update all the claim endpoints to pass through an if statement.
There was a problem hiding this comment.
We need to do this on claim, only when the storage is empty.
There was a problem hiding this comment.
I think it would be better.
There was a problem hiding this comment.
I thought about adding it but I don't think it will bring any real improvement. An if statement would require a few extra storage reads (we would need to compute the current week), so in the end gas won't be saved, but at the same time it would add some extra logic with the if statement, which in turn would complicate the review/audit/testing parts.
| let boosted_rewards = self.claim_only_boosted_payment(user); | ||
|
|
||
| self.set_farm_supply_for_current_week(&storage_cache.farm_token_supply); |
There was a problem hiding this comment.
do we have to do this every single time ?
There was a problem hiding this comment.
Commented above. Also, this is how it already works for the other endpoints (enter, exit, claim).
…-supply-on-claim-fix
psorinionut
changed the title
…-tests farm supply for week fix unit tests
sasurobert
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.