Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CARv2 IndexSorted #220

Merged
merged 1 commit into from
Jun 26, 2021
Merged

Add CARv2 IndexSorted #220

merged 1 commit into from
Jun 26, 2021

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 25, 2021

mvdan
mvdan approved these changes Jun 25, 2021
View reviewed changes
Copy link

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. Do we want to link to the spec when that's merged?

@mvdan
Copy link

mvdan commented Jun 25, 2021

Merged into the go-car wip-v2 branch: ipld/go-car#108

willscott
willscott approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping me honest in actually formalizing this 👍

@rvagg rvagg merged commit 68fad7e into master Jun 26, 2021
@rvagg rvagg deleted the rvagg/carv2-idx branch June 26, 2021 01:01
@masih masih mentioned this pull request Jul 12, 2021
Merged
masih added a commit to multiformats/go-multicodec that referenced this pull request Jul 13, 2021
@masih
Run go generate to generate the latest codecs
b421db6 
Re-generate code by running `go generate` to pick up the latest codecs
added to the codec table.

Most notable codec generated here is the CarIndexSorted codec needed in
go-car v2.

See:
- https://github.com/ipld/go-car
- https://github.com/ipld/go-car/milestone/1
- https://github.com/ipld/go-car/blob/wip-v2/v2/index/index.go

Relates to:
- multiformats/multicodec#220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

@willscott willscott willscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvagg @mvdan @willscott