fix: use Multiaddr as class name #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmetic change ahead. When logging multaddrs in browsers `DefaultMultiaddr` appears in the console. It's called this to prevent a collision with the `Multiaddr` TypeScript interface name. The interfaces are removed at compile time so here we import the interface with a different name, freeing up the `Multiaddr` symbol to be used as the class name.
achingbrain
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
## [12.1.9](v12.1.8...v12.1.9) (2023-11-06) ### Bug Fixes * use Multiaddr as class name ([#352](#352)) ([35348cd](35348cd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmetic change ahead.
When logging multaddrs in browsers
DefaultMultiaddrappears in the console. It's called this to prevent a collision with theMultiaddrTypeScript interface name which is the horse leading the cart.The interfaces are removed at compile time so here we import the interface with a different name, freeing up the
Multiaddrsymbol to be used as the class name which will now appear in the console.This change is backwards compatible because everything is hidden behind the
multiaddrfactory function.