Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JSON round trip works as expected #85

Merged
merged 2 commits into from
Mar 4, 2019
Merged

fix: JSON round trip works as expected #85

merged 2 commits into from
Mar 4, 2019

Conversation

jchris
Copy link
Contributor

@jchris jchris commented Mar 1, 2019

Fix for #54

Adds a test case, and simply reuses the toString implementation.

Chris Anderson added 2 commits March 1, 2019 12:24
fix: implement JSON so roundtrip works as expected
7b3af64 
This commit adds a test case, and simply reuses the
the `toString` implementation.
style: remove semicolon to pass lint
5fdfe43
jacobheun
jacobheun approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for the PR!

@jacobheun jacobheun merged commit 1977874 into multiformats:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchris @jacobheun