Add ip validations to ip addr formats #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good to me. Though @diasdavid can you please also have a look, I don't feel like knowing enough about js-multiaddr to merge this myself. |
|
Thank you @zcstarr :) |
dryajov
pushed a commit
to dryajov/js-multiaddr
that referenced
this pull request
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR here addresses ip validation issue with ip based js multiaddr #58.
The existing behavior translates invalid ip addresses to valid ip addresses, and throws on some invalid ip addresses, but not all.
This patch includes ip-address package which is already apart of js-libp2p-switch to validate ip addresses prior to translating them to and from String to Buffer.