fix: replace node buffers with uint8arrays #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
4 tasks
It's a type test that's run with |
All uses of node Buffers have been replaced with Uint8Arrays. Also redundant modules have been removed from package.json BREAKING CHANGES: - Where node Buffers were returned, now Uint8Arrays are - The `.buffer` property has been renamed `.bytes` similar to [email protected]
achingbrain
force-pushed
the
fix/replace-node-buffers-with-uint8arrays
branch
from
29354ad
to
30186c4
Compare
Call me old fashioned, but tests should do more than just compile something 😆 I've reinstated the file but downgraded aegir as the current version tries to lint and run that file as a test which fails. |
jacobheun
approved these changes
Aug 7, 2020
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All uses of node Buffers have been replaced with Uint8Arrays.
Also redundant modules have been removed from package.json
BREAKING CHANGES:
.bufferproperty has been renamed.bytessimilar to [email protected]