Run go generate to generate the latest codecs
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-generate code by running `go generate` to pick up the latest codecs added to the codec table. Most notable codec generated here is the CarIndexSorted codec needed in go-car v2. See: - https://github.com/ipld/go-car - https://github.com/ipld/go-car/milestone/1 - https://github.com/ipld/go-car/blob/wip-v2/v2/index/index.go Relates to: - multiformats/multicodec#220
marten-seemann
approved these changes
Jul 12, 2021
Merged
mvdan
reviewed
Jul 13, 2021
| Bencode Code = 0x63 // bencode | ||
|
|
||
| // DagPb is tagged "ipld" and described by: MerkleDAG protobuf. | ||
| // DagPb is tagged "ipld" and described by: permanent. |
There was a problem hiding this comment.
surely these are all regressions? the old description was better
There was a problem hiding this comment.
I am with you. Maybe something to improve in go generate or the CSV structure?
masih
added a commit
to ipld/go-car
that referenced
this pull request
Jul 13, 2021
Use the codec dedicated to CAR index sorted when marshalling and unmarshalling `indexSorted`. Note, the code depends on a specific commit of `go-multicodec` `master` branch. This needs to be replaced with a tag once a release is made on the go-multicodec side later. Unexport index APIs that should not be exposed publicly. Remove `Builder` now that it is not needed anywhere. Move `insertionIndex` into `blockstore` package since that's the only place it is used. Introduce an index constructor that takes multicodec code and instantiates an index. Fix ignored errors in `indexsorted.go` during marshalling/unmarshlling. Rename index constructor functions to use consistent terminology; i.e. `new` instead if `mk`. Remove redundant TODOs in code. Relates to: - multiformats/go-multicodec#46
mvdan
pushed a commit
to ipld/go-car
that referenced
this pull request
Jul 16, 2021
Use the codec dedicated to CAR index sorted when marshalling and unmarshalling `indexSorted`. Note, the code depends on a specific commit of `go-multicodec` `master` branch. This needs to be replaced with a tag once a release is made on the go-multicodec side later. Unexport index APIs that should not be exposed publicly. Remove `Builder` now that it is not needed anywhere. Move `insertionIndex` into `blockstore` package since that's the only place it is used. Introduce an index constructor that takes multicodec code and instantiates an index. Fix ignored errors in `indexsorted.go` during marshalling/unmarshlling. Rename index constructor functions to use consistent terminology; i.e. `new` instead if `mk`. Remove redundant TODOs in code. Relates to: - multiformats/go-multicodec#46 Address review comments * Rename constructor of index by codec to a simpler name and update docs. * Use multicodec.Code as constant instead of wrappint unit64 every time.
Jorropo
pushed a commit
to ipfs/boxo
that referenced
this pull request
Mar 22, 2023
Use the codec dedicated to CAR index sorted when marshalling and unmarshalling `indexSorted`. Note, the code depends on a specific commit of `go-multicodec` `master` branch. This needs to be replaced with a tag once a release is made on the go-multicodec side later. Unexport index APIs that should not be exposed publicly. Remove `Builder` now that it is not needed anywhere. Move `insertionIndex` into `blockstore` package since that's the only place it is used. Introduce an index constructor that takes multicodec code and instantiates an index. Fix ignored errors in `indexsorted.go` during marshalling/unmarshlling. Rename index constructor functions to use consistent terminology; i.e. `new` instead if `mk`. Remove redundant TODOs in code. Relates to: - multiformats/go-multicodec#46 Address review comments * Rename constructor of index by codec to a simpler name and update docs. * Use multicodec.Code as constant instead of wrappint unit64 every time. This commit was moved from ipld/go-car@2b593c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-generate code by running
go generateto pick up the latest codecsadded to the codec table.
Most notable codec generated here is the
CarIndexSortedcodec needed ingo-car v2.
See:
Relates to: