Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please convert output with latest environment files #4

Closed
rsharma02-entrata opened this issue Oct 21, 2022 · 7 comments
Closed

Please convert output with latest environment files #4

rsharma02-entrata opened this issue Oct 21, 2022 · 7 comments

Comments

@rsharma02-entrata
Copy link

Please check this-
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files

@mukunku
Copy link
Owner

mukunku commented Oct 28, 2022

Could you please explain a bit more in detail what should be changed? The github action doesn't use yaml to generate environment variables. It's all javascript. If you were worried about deprecated warnings try out v1.1.0 now.

@edlerd
Copy link
Contributor

edlerd commented Oct 28, 2022

I think it refers to a warning, that set-output is deprecated. But this is only true, while inside a workflow yaml file. But in an action, it is actually fine to still use core.setOutput. Updating to the latest @actions/core version should fix it.

I found the same problem and the possible solution here: actions/toolkit#1218

@mukunku
Copy link
Owner

mukunku commented Oct 28, 2022

Thanks @edlerd . I bumped the @actions/core version to 1.10 and the warning went away. I updated the v1.1.0 release instead of publishing a new one.

@mukunku mukunku closed this as completed Oct 28, 2022
@pmalek
Copy link

pmalek commented Jan 5, 2023

@mukunku
Copy link
Owner

mukunku commented Jan 8, 2023

Hi @mukunku 👋

Isn't this still using @actions/core 1.9.1? As per:

* https://github.com/mukunku/tag-exists-action/blob/v1.2.0/package-lock.json#L12

* and https://github.com/mukunku/tag-exists-action/blob/v1.2.0/package.json#L21

?

Hey @pmalek,

I believe ^1.9.1 should still resolve to 1.10.0 . Not sure why npm didn't update the package.json to make 1.10.0 the minimum though.

I'm basing this on this article:

If you see ^1.0.2 it means to install version 1.0.2 or the latest minor or patch version such as 1.1.0.

@KevinRohn
Copy link
Contributor

Please check the open PR.

It`s still not resolved.

I fixed it in this commit:
3e6a721

@pof-kevinbutto
Copy link

@mukunku thank you for this action!
any update on this though? I'm still getting the "set-output command is deprecated " warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants