Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve the docs #2366

Merged
merged 2 commits into from
Jul 25, 2023
Merged

[docs] Improve the docs #2366

merged 2 commits into from
Jul 25, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 25, 2023 •
edited
Loading

@bharatkashyap bharatkashyap added the docs Improvements or additions to the documentation label Jul 25, 2023
@oliviertassinari
Copy link
Member Author

A few more fixes for the homepage

@Janpot
Copy link
Member

Janpot commented Jul 25, 2023 •
edited
Loading

One thing I noticed is that the padding on this badge feels a bit off

Screenshot 2023-07-25 at 14 58 33

To me it feels unbalanced top vs. bottom. It's a detail though, just once you see it... 🙂

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 25, 2023 •
edited
Loading

It looks horrible in your case, agree.

But I can't reproduce this one on macOS, it's fine here:

Screenshot 2023-07-26 at 00 18 42

@oliviertassinari oliviertassinari merged commit 6a7875b into mui:master Jul 25, 2023
1 check passed
@oliviertassinari oliviertassinari deleted the polish-docs branch July 25, 2023 22:19
@prakhargupta1
Copy link
Member

It would be great if we could deploy these changes today, as I want to direct some of the users to the examples page.

@bharatkashyap
Copy link
Member

it looks horrible, agree

Should we remove the button? It came from the need here: #2335

@Janpot
Copy link
Member

Janpot commented Jul 26, 2023

I don't see it anymore, not sure what has changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliviertassinari @Janpot @prakhargupta1 @bharatkashyap