Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sinon to ^15.2.0 #9063

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Bump sinon to ^15.2.0 #9063

merged 2 commits into from
Jun 28, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 21, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sinon (source) ^15.0.4 -> ^15.2.0 age adoption passing confidence

Release Notes

sinonjs/sinon

v15.2.0

Compare Source

  • 66b0081e
    Use fake-timers v10.1.0 re-released as v10.3.0 (Carl-Erik Kopseng)

    Version 10.2.0 of fake-timers had an unexpected breaking
    change. We re-released 10.1.0 as 10.3.0 to force users
    into jumping over the deprecated version.

    v10.2.0 was re-released as v11.0.0 and will be part of
    the next Sinon major

  • a79ccaeb
    Support callable instances (#​2517) (bojavou)
    • Support callable instances

    • Clean prettier lint


    Co-authored-by: - <->

  • d220c995
    fix: bundling compatibility with webpack@5 (#​2519) (Avi Vahl)
    • fix: bundling compatibility with webpack@5

    when using webpack v5 to bundle code that calls require('sinon') (cjs) , it would have defaulted to "exports->require" and fail with multiple node-api requirements (util, timers, etc.)

    this patch ensures that anyone who bundles sinon for browser gets the (browser-compatible) esm version.

    tested on both webpack v5 and v4. should be noted that v4 worked even without this patch, as it automatically injected polyfills. v5 no longer does so. with this PR, people using webpack@4 to bundle sinon at least see size improvement, as the polyfills are no longer required.

    • fix: revert change for package.json -> "browser"

    browserify doesn't seem to like esm. leave that entry point alone, and ensure "exports" -> "browser" (which webpack@5 uses) is esm.

Released by Carl-Erik Kopseng on 2023-06-20.

v15.1.2

Compare Source

  • 02b73aed
    Update lock file after removing node_modules ... (Carl-Erik Kopseng)

Released by Carl-Erik Kopseng on 2023-06-12.

v15.1.1

Compare Source

  • 194fc2ef
    Change fake-timers version to specifically target the one containing the 'jump' feature (Carl-Erik Kopseng)

    Instead of the later (breaking) version. See #​470

  • 05f05ac3
    docs: Remove threw(obj) from docs (#​2513) (Morgan Roderick)

    Since the introduction of threw in

    0feec9f, no one have reported that

    threw(obj) doesn't work as the documentation states.

    const sinon = require("sinon");
    
    const o = { pie: "apple" };
    
    const f = sinon.fake.throws(o);
    
    f();
    
    // this is supposed to return true
    
    f.threw(o);
    
    // => false

    Since it has been 12+ years without an error report, it's safe to assume

    that no one uses the threw method in this way. Let's remove it from

    the documentation.

Released by Carl-Erik Kopseng on 2023-06-12.

v15.1.0

Compare Source

  • 79e719f2
    Ensure we use a fake-timers version with clock.jump (Carl-Erik Kopseng)
  • b2a4df5a
    Add docs for clock.jump method (#​2512) (Jason O'Neill)
  • f096abff
    fix (#​2514): only force new or inherited descriptors to be configurable (#​2515) (Carl-Erik Kopseng)

Released by Carl-Erik Kopseng on 2023-05-18.


Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Update of dependencies label May 21, 2023
@mui-bot
Copy link

mui-bot commented May 21, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9063--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 436.9 801.4 665.8 635.6 148.929
Sort 100k rows ms 600.2 893.4 813 761.3 105.733
Select 100k rows ms 175.8 276.7 205.2 212.7 37.113
Deselect 100k rows ms 131.8 311.7 181.7 203.2 62.192

Generated by 🚫 dangerJS against a5e5d12

@LukasTy
Copy link
Member

LukasTy commented May 26, 2023

@mui/xgrid 81 DataGrid tests seem to be failing after this update. 🤔
Could you take a look once you get the chance? 🙏

@cherniavskii
Copy link
Member

I don't know how to fix the failing tests.
They started failing because of sinonjs/fake-timers#467, but I don't know why 🤷🏻‍♂️

@ZeeshanTamboli
Copy link
Member

Same issue on Material UI for a Tooltip test - mui/material-ui#37430

@renovate renovate bot changed the title Bump sinon to ^15.1.0 Bump sinon to ^15.1.1 Jun 12, 2023
@renovate renovate bot changed the title Bump sinon to ^15.1.1 Bump sinon to ^15.1.2 Jun 12, 2023
@renovate renovate bot changed the title Bump sinon to ^15.1.2 Bump sinon to ^15.2.0 Jun 20, 2023
@DiegoAndai
Copy link
Member

@mui/x to solve the regression test: https://github.com/mui/material-ui/pull/37430/files#diff-c6283f5fa0c0e1715f4d0fdac062964728ebcd04b2868febd6efa5b1b4017600R28

@LukasTy
Copy link
Member

LukasTy commented Jun 28, 2023

to solve the regression test: https://github.com/mui/material-ui/pull/37430/files#diff-c6283f5fa0c0e1715f4d0fdac062964728ebcd04b2868febd6efa5b1b4017600R28

Thank you for looking into it! 🙏
That's a totally bizarre and annoying issue... 🤷

@renovate
Copy link
Contributor Author

renovate bot commented Jun 28, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@LukasTy LukasTy merged commit 98ea130 into master Jun 28, 2023
@LukasTy LukasTy deleted the renovate/sinon-15.x branch June 28, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants