-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Fix flaky tests #8097
[test] Fix flaky tests #8097
Conversation
Netlify deploy previewNetlify deploy preview: https://deploy-preview-8097--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice and clean improvement! 💯
packages/grid/x-data-grid-pro/src/tests/detailPanel.DataGridPro.test.tsx
Outdated
Show resolved
Hide resolved
packages/grid/x-data-grid-pro/src/tests/detailPanel.DataGridPro.test.tsx
Outdated
Show resolved
Hide resolved
@LukasTy let me know if you notice any flaky tests after merging this PR. |
I've seen some false negatives in #8108, I'll look into it later |
Fixes #7986 (comment)
If it works well, I'll submit a PR that would remove
fake
clock in other tests as well.