-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[support-infra] Add release announcement to GitHub workflows #11867
[support-infra] Add release announcement to GitHub workflows #11867
Conversation
…or string into the changelog script
Deploy preview: https://deploy-preview-11867--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, @michelengelen! Thank you for pushing forward on this front!
name: Send message to discord | ||
steps: | ||
- name: parse and send message | ||
uses: michelengelen/discord-message-action@02af30a15955ecf718049bc33b0efabf6f626e0b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, maybe we should review the action itself? Since it's the most essential part of the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes ... please go ahead. It's my private one, so nothing to hide there! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the link to it for reference: https://github.com/michelengelen/discord-message-action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked it - seems good. I think we can move forward and add this to the release workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
I guess we don't use https://github.com/marketplace/actions/github-releases-to-discord to have the highlight extract.
No, we don't, since every action available was either not working or did not have the feature set we wanted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Can this be extended to the Core side of the world, too? If yes, a follow up question would be if it is possible to cherry pick which announcements go to Discord?
Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Michel Engelen <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Michel Engelen <[email protected]>
Can we move on with this PR or are there any change requests from either of you? |
Signed-off-by: Michel Engelen <[email protected]> Co-authored-by: Olivier Tassinari <[email protected]>
…#12843) Signed-off-by: Michel Engelen <[email protected]> Co-authored-by: Olivier Tassinari <[email protected]>
Signed-off-by: Michel Engelen <[email protected]> Co-authored-by: Olivier Tassinari <[email protected]>
…) (mui#12843) Signed-off-by: Michel Engelen <[email protected]> Co-authored-by: Olivier Tassinari <[email protected]>
This action will send a message to the #announcements channel on our discord server when there is a new release (events:
release:published
andrelease:prereleased
).For this to work we need to add a separator line into the changelog. This will be a comment string sitting just before the detailed changes.
This string needs to stay in order for the script to know where the highlights end.
The reason why we are doing this is that Discord does not allow messages to be above 2000 characters.
The message posted will look like this (tested with the v7-beta-0 Changelog):