Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] [DataGridPro]About Sorting on iPad #8762

Closed
2 tasks done
e12879 opened this issue Apr 26, 2023 · 10 comments · Fixed by #9076
Closed
2 tasks done

[question] [DataGridPro]About Sorting on iPad #8762

e12879 opened this issue Apr 26, 2023 · 10 comments · Fixed by #9076
Labels
component: data grid This is the name of the generic UI component, not the React module! mobile Targets mobile platform plan: Pro Impact at least one Pro user support: commercial Support request from paid users support: question Community support but can be turned into an improvement

Comments

@e12879
Copy link

e12879 commented Apr 26, 2023

Order ID or Support key 💳 (optional)

58043

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

The problem in depth 🔍

I am using mui/x-data-grid-pro.
Please tell me about the sort function of DataGridPro on iPad (Safari).
Android tablet (Google Chrome) sorts with 1Tap.
On the other hand, iPad sorts with 2Tap. Is this the specification?
If possible, I would like to sort with 1Tap even on iPad (Safari). Is there a way?

supplementary explanation:
Column headers only have sort functionality.

Your environment 🌎

My environment is as follows.
■npx @mui/envinfo
  System:
   OS: Windows 10 10.0.19044
  Binaries:
    Node: 14.21.3 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 6.14.18 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.19041.1266.0), Chromium (112.0.1722.48)

 

■Actual machine environment in use
  Ipad 6 iOS:15.7.1
  iPad Pro iOS:16.3.1
  Galaxy Tab A8:Android11

@e12879 e12879 added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: commercial Support request from paid users labels Apr 26, 2023
@zannager zannager added support: question Community support but can be turned into an improvement component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user labels Apr 26, 2023
@m4theushw
Copy link
Member

@mui/xgrid Could someone test the DataGrid on the iOS simulator or on a real device? With the DevTools only one tap is enough to trigger the sorting.

@m4theushw m4theushw removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Apr 27, 2023
@cherniavskii
Copy link
Member

I can reproduce this on iOS simulator:

Screen.Recording.2023-04-28.at.10.21.47.mov

@cherniavskii cherniavskii added the mobile Targets mobile platform label Apr 28, 2023
@cherniavskii
Copy link
Member

@cherniavskii
Copy link
Member

Similar issue was reported for the Autocomplete component in mui/material-ui#21049

@cherniavskii
Copy link
Member

I'm not sure there's an easy fix here. To make sorting work on the first click, we have to get rid of hover styles on mobile, therefore it will be impossible to open the column menu (column menu icon is only showed on hover)

@e12879
Copy link
Author

e12879 commented May 9, 2023

@cherniavskii @m4theushw
thank you for your reply.
Do you have any plans to fix it in DataGridPro?
If it doesn't, I'm aware that I need to remove the hover.

@cherniavskii
Copy link
Member

@e12879 We do not have plans for a fix yet, as it's unclear how to make the column menu work without hover.

cc @gerdadesign Maybe we can reconsider how column headers work on touch devices? E.g. show them in "hovered" state by default, so that you always see the icons in the column headers, as well as resize handles?

@romgrk
Copy link
Contributor

romgrk commented May 22, 2023

An alternative I sometimes see on mobile is to use a long press to replace the hover trigger.

@MBilalShafi
Copy link
Member

MBilalShafi commented May 23, 2023

you always see the icons in the column headers, as well as resize handles

This makes sense to me because:

  1. The content shown on mobile screens is mostly not that much and it won't look heavy to show the icons all the time
  2. There's no hover on mobile rather it is a tap, so showing the icons may save some extra taps/confusion on other (non-iOS) devices too

@gerdadesign
Copy link
Member

+1 for showing on mobile what is typically reserved for hover on desktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! mobile Targets mobile platform plan: Pro Impact at least one Pro user support: commercial Support request from paid users support: question Community support but can be turned into an improvement
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants