Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Column headers separators covers a portion of the menu button #5302

Closed
2 tasks done
jvega190 opened this issue Jun 23, 2022 · 4 comments
Closed
2 tasks done
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer

Comments

@jvega190
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

The menu button of the column headers (to show actions menu) is not entirely clickable, it seems like the header separator is covering a part of the button.

Expected behavior 🤔

The whole menu button of the columns headers should be clickable.

Steps to reproduce 🕹

Steps:

  1. https://codesandbox.io/s/data-grid-community-forked-0r303e
  2. Try to click on the right part of a menu button of a column header (see how it doesn't hover until you react the icon of the button).

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Order ID 💳 (optional)

No response

@jvega190 jvega190 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 23, 2022
@cherniavskii cherniavskii added bug 🐛 Something doesn't work docs Improvements or additions to the documentation status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Jun 30, 2022
@m4theushw
Copy link
Member

The resize icon has 24px, but most of it is empty because the actual icon is only a vertical line. Since it's absolutely positioned, there's a conflict between the menu icon. I think we could use a custom resize icon, still based on the MUI icon, but taking less space. As example, AG Grid uses only 8px for the resize icon, while we use 24px. We could also play with increasing the right margin between the menu icon and separator.

@m4theushw m4theushw added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! design: ux and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 30, 2022
@cherniavskii
Copy link
Member

This was reported earlier in #4192 as well

@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed design: ux labels Aug 18, 2023
@KenanYusuf
Copy link
Contributor

Fixed in #14293

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

We value your feedback @jvega190! How was your experience with our support team?
If you could spare a moment, we'd love to hear your thoughts in this brief Support Satisfaction survey. Your insights help us improve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer
Projects
None yet
Development

No branches or pull requests

5 participants