Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fields] Make splitFieldInternalAndForwardedProps public #14515

Closed
flaviendelangle opened this issue Sep 6, 2024 · 1 comment · Fixed by #14514
Closed

[fields] Make splitFieldInternalAndForwardedProps public #14515

flaviendelangle opened this issue Sep 6, 2024 · 1 comment · Fixed by #14514
Assignees
@flaviendelangle
Labels
component: pickers This is the name of the generic UI component, not the React module! customization: extend Logic customizability feature: Keyboard editing Related to the pickers keyboard edition

Comments

@flaviendelangle
Copy link
Member

flaviendelangle commented Sep 6, 2024 •
edited by github-actions bot
Loading

When creating a custom component to pass to the field slot of a picker, you need to extract all the internal props (all the validation props, props like format, formatDensity, shouldRespectLeadingZeros, ...) before forwarding the props to the DOM (even if you don't use useField at all).

Making this hook public will help providing actual custom field like the masked-based field and the read-only field.

Search keywords:
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 6, 2024
@flaviendelangle flaviendelangle added component: pickers This is the name of the generic UI component, not the React module! customization: extend Logic customizability feature: Keyboard editing Related to the pickers keyboard edition and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 6, 2024
@flaviendelangle flaviendelangle self-assigned this Sep 6, 2024
@flaviendelangle flaviendelangle mentioned this issue Sep 11, 2024
Merged
4 tasks
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@flaviendelangle flaviendelangle mentioned this issue Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module! customization: extend Logic customizability feature: Keyboard editing Related to the pickers keyboard edition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fields] Improve useSplitFieldProps and make it public flaviendelangle/mui-x
1 participant
@flaviendelangle