New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts] Follow a single naming pattern in context #14028

Closed

JCQuintas opened this issue Jul 30, 2024 · 3 comments

Labels

breaking change component: charts v8.x

Member

JCQuintas commented Jul 30, 2024 •

edited by github-actions bot

Loading

Right now we follow both XxxContextProvider and XxxProvider for Context Providers in the codebase.

The goal is to follow a single pattern.

Search keywords:

The text was updated successfully, but these errors were encountered:

JCQuintas added breaking change component: charts v8.x labels

Member

flaviendelangle commented Jul 30, 2024 •

edited

Loading

If you want to provide a smooth migration, could you do something like this?

- export const XxxContextProvider = React.creactContext({});
+ export const XxxProvider = React.createContext({});
+ /**
+   * @deprecated Use XxxProvider instead
+   */
+ export const XxxContextProvider = XxxProvider;

And then drop the deprecated one in v8

alexfauquette mentioned this issue

[discussion] Preparing v8 #13188

Open

12 tasks

Member

alexfauquette commented Jan 17, 2025

@JCQuintas Can we close this one, or do you still see something to do about it?

JCQuintas closed this as completed

github-actions bot commented Jan 17, 2025

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment